Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/5288#issuecomment-94525599
  
    /cc @andrewor14, what do you think about this fix?  The inheritance + 
cancellation tests here address an incredibly obscure corner-case that most 
users might not hit or expect to work (since I don't think that we ever 
explicitly state that job groups will be inherited across threads).  The 
defensive copy of Properties seems like a good change by itself, though.
    
    I'd like to try to get some closure on this issue by either deciding that 
we're going to support the inheritance feature as it was originally described 
or by removing this feature and instructing users to manually set job groups in 
child threads; at this point, I think that either option could work since the 
current behavior is broken.  We could also decide to just leave the inheritance 
alone and only do the copying change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to