maropu commented on a change in pull request #30923:
URL: https://github.com/apache/spark/pull/30923#discussion_r548827028
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
##########
@@ -49,8 +48,6 @@ abstract class RDG extends UnaryExpression with
ExpectsInputTypes with Stateful
@transient protected lazy val seed: Long = seedExpression match {
case Literal(s, IntegerType) => s.asInstanceOf[Int]
case Literal(s, LongType) => s.asInstanceOf[Long]
Review comment:
I thin it is bad that the argument of `rand` depends on the optimizer
rules and it is a minor bug, so could you fix it in a separate PR first for
backporting the fix? cc: @HyukjinKwon @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
