cloud-fan commented on a change in pull request #30918:
URL: https://github.com/apache/spark/pull/30918#discussion_r548827992
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala
##########
@@ -226,7 +227,8 @@ case class RelationConversions(
tableDesc.partitionColumnNames.isEmpty && isConvertible(tableDesc)
&&
SQLConf.get.getConf(HiveUtils.CONVERT_METASTORE_CTAS) =>
// validation is required to be done here before relation conversion.
- DDLUtils.checkDataColNames(tableDesc.copy(schema = query.schema))
+ val tableSchema =
CharVarcharUtils.replaceCharVarcharWithStringInSchema(query.schema)
+ DDLUtils.checkDataColNames(tableDesc.copy(schema = tableSchema))
Review comment:
do we really need to restore char/varchar for this `checkDataColNames`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
