cloud-fan commented on a change in pull request #30898:
URL: https://github.com/apache/spark/pull/30898#discussion_r549241333
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -484,6 +484,9 @@ object SimplifyConditionals extends Rule[LogicalPlan] with
PredicateHelper {
case If(cond, FalseLiteral, l @ Literal(null, _)) if !cond.nullable =>
And(Not(cond), l)
case If(cond, TrueLiteral, l @ Literal(null, _)) if !cond.nullable =>
Or(cond, l)
+ case CaseWhen(Seq((cond, TrueLiteral)), Some(FalseLiteral)) => cond
Review comment:
do we already optimize single-branch CASE WHEN to IF and get this
optimized?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
