Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4688#discussion_r28728339
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -122,7 +126,7 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
             } else {
               logInfo("Registered executor: " + executorRef + " with ID " + 
executorId)
               context.reply(RegisteredExecutor)
    -
    +          latestTokens.foreach(x => context.reply(NewTokens(x)))
    --- End diff --
    
    So this is weird. You just "replied" in the line above, so "replying" here 
doesn't make sense. Perhaps you mean `send`?
    
    Also, why not stash the tokens in the `RegisteredExecutor` message? One 
less message to send!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to