MaxGekk commented on a change in pull request #30538:
URL: https://github.com/apache/spark/pull/30538#discussion_r549725116
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterTableDropPartitionSuiteBase.scala
##########
@@ -144,4 +145,14 @@ trait AlterTableDropPartitionSuiteBase extends QueryTest
with DDLCommandTestUtil
checkPartitions(t)
}
}
+
+ test("SPARK-33591: null as a partition value") {
+ withNamespaceAndTable("ns", "tbl") { t =>
+ sql(s"CREATE TABLE $t (col1 INT, p1 STRING) $defaultUsing PARTITIONED BY
(p1)")
+ sql(s"ALTER TABLE $t ADD PARTITION (p1 = null)")
Review comment:
This is common test suite for all catalogs. Yes, it works for Hive
external catalog too.
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterTableDropPartitionSuiteBase.scala
##########
@@ -144,4 +145,14 @@ trait AlterTableDropPartitionSuiteBase extends QueryTest
with DDLCommandTestUtil
checkPartitions(t)
}
}
+
+ test("SPARK-33591: null as a partition value") {
+ withNamespaceAndTable("ns", "tbl") { t =>
+ sql(s"CREATE TABLE $t (col1 INT, p1 STRING) $defaultUsing PARTITIONED BY
(p1)")
+ sql(s"ALTER TABLE $t ADD PARTITION (p1 = null)")
Review comment:
This is the common test suite for all catalogs. Yes, it works for Hive
external catalog too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
