Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4435#discussion_r28732087
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -149,7 +159,13 @@ class HistoryServer(
        *
        * @return List of all known applications.
        */
    -  def getApplicationList(): Iterable[ApplicationHistoryInfo] = 
provider.getListing()
    +  def getApplicationList(): Iterable[ApplicationHistoryInfo] = {
    +    provider.getListing()
    +  }
    +
    +  def getApplicationInfoList: Seq[ApplicationInfo] = {
    +    getApplicationList().map { 
ApplicationsListResource.appHistoryInfoToPublicAppInfo }.toSeq
    --- End diff --
    
    Is this transformation lazy? Otherwise it can cause memory usage to shoot 
up considerably when this method is called (which can happen from multiple 
concurrent user requests).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to