cloud-fan commented on a change in pull request #30881:
URL: https://github.com/apache/spark/pull/30881#discussion_r549933484
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -235,8 +237,21 @@ class ResolveSessionCatalog(
case DescribeRelation(ResolvedV1TableOrViewIdentifier(ident),
partitionSpec, isExtended) =>
DescribeTableCommand(ident.asTableIdentifier, partitionSpec, isExtended)
- case DescribeColumn(ResolvedV1TableOrViewIdentifier(ident), colNameParts,
isExtended) =>
- DescribeColumnCommand(ident.asTableIdentifier, colNameParts, isExtended)
+ case DescribeColumn(ResolvedViewIdentifier(ident), column:
UnresolvedAttribute, isExtended) =>
+ // For views, the column will not be resolved by `ResolveReferences`
because
+ // `ResolvedView` stores only the identifier.
+ DescribeColumnCommand(ident.asTableIdentifier, column.nameParts,
isExtended)
+
+ case DescribeColumn(ResolvedV1TableIdentifier(ident), column, isExtended)
=>
+ column match {
+ case u: UnresolvedAttribute =>
+ throw QueryCompilationErrors.columnDoesNotExistError(u.name)
+ case a: Attribute =>
+ DescribeColumnCommand(ident.asTableIdentifier, a.qualifier :+
a.name, isExtended)
Review comment:
How about `ident.asMultipartIdentifier :+ a.name`? Then we don't need to
add qualifiers to `ResolvedTable`.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -235,8 +237,21 @@ class ResolveSessionCatalog(
case DescribeRelation(ResolvedV1TableOrViewIdentifier(ident),
partitionSpec, isExtended) =>
DescribeTableCommand(ident.asTableIdentifier, partitionSpec, isExtended)
- case DescribeColumn(ResolvedV1TableOrViewIdentifier(ident), colNameParts,
isExtended) =>
- DescribeColumnCommand(ident.asTableIdentifier, colNameParts, isExtended)
+ case DescribeColumn(ResolvedViewIdentifier(ident), column:
UnresolvedAttribute, isExtended) =>
+ // For views, the column will not be resolved by `ResolveReferences`
because
+ // `ResolvedView` stores only the identifier.
+ DescribeColumnCommand(ident.asTableIdentifier, column.nameParts,
isExtended)
+
+ case DescribeColumn(ResolvedV1TableIdentifier(ident), column, isExtended)
=>
+ column match {
+ case u: UnresolvedAttribute =>
+ throw QueryCompilationErrors.columnDoesNotExistError(u.name)
+ case a: Attribute =>
+ DescribeColumnCommand(ident.asTableIdentifier, a.qualifier :+
a.name, isExtended)
Review comment:
How about `ident.asMultipartIdentifier :+ a.name`? Then we don't need to
add qualifiers to `ResolvedTable.output`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
