Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2342#issuecomment-94583906
Hi @sarutak - I did a pretty thorough pass on this and I have some
feedback. First some "high level" stuff:
- The overall architecture. I'm +1 on using this timelines library, it
seems like it has a pretty nice interface and simplifies a lot. This also
largely uses things we already have inside of existing listeners, which is good.
- Using this vs the approach in #5547. I think a good answer here is to use
this vis.js library for the jobs page and then use a custom D3-based approach
for the stage page, where we need to be careful about scalability to thousands
of events (e.g. thousands of tasks). So with that in mind, I'd propose removing
the stage functionality for now from this patch and only having the other pages.
- What does it look like if you just display all stages instead of doing
jobs-level view? I wonder if that would be better. Then we could give stages in
the same job the same color.
There are also some lower level notes inline about code cleanliness, etc.
- It would be good to have a visual line indicating the start of the
application.
- It would be nice if you could use <ctrl>+scroll to zoom, so that we could
remove the scroll lock. Is this possible with the library?
- It would be nice if I could mouse over a job and then have it highlight
the corresponding job on the table below.
Ping @andrewor14 as well case I missed anything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
