maropu commented on a change in pull request #30978:
URL: https://github.com/apache/spark/pull/30978#discussion_r550197275
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -272,5 +260,19 @@ object SharedState extends Logging {
sparkWarehouseDir
}
logInfo(s"Warehouse path is '$warehousePath'.")
+ val confClone = sparkConf.clone()
Review comment:
This change add a unnecessary overhead in the `SparkSQLCLIDriver` side?
https://github.com/apache/spark/blob/ba974ea8e4cc8075056682c2badab5ca64b90047/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala#L136
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/internal/SharedState.scala
##########
@@ -272,5 +260,19 @@ object SharedState extends Logging {
sparkWarehouseDir
}
logInfo(s"Warehouse path is '$warehousePath'.")
+ val confClone = sparkConf.clone()
Review comment:
This change adds a unnecessary overhead in the `SparkSQLCLIDriver` side?
https://github.com/apache/spark/blob/ba974ea8e4cc8075056682c2badab5ca64b90047/sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala#L136
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
