cloud-fan commented on a change in pull request #30902:
URL: https://github.com/apache/spark/pull/30902#discussion_r550198242
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala
##########
@@ -303,11 +304,23 @@ object JdbcUtils extends Logging {
} else {
rsmd.isNullable(i + 1) != ResultSetMetaData.columnNoNulls
}
- val metadata = new MetadataBuilder().putLong("scale", fieldScale)
+ val metadata = new MetadataBuilder()
+ // SPARK-33888
+ // - include scale in metadata for only DECIMAL & NUMERIC
+ // - include TIME type metadata
+ // - always build the metadata
+ dataType match {
+ // scalastyle:off
+ case java.sql.Types.NUMERIC => metadata.putLong("scale", fieldScale)
+ case java.sql.Types.DECIMAL => metadata.putLong("scale", fieldScale)
+ case java.sql.Types.TIME => metadata.putBoolean("logicaltimetype",
true)
Review comment:
how about `logical_time_type `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
