dongjoon-hyun commented on a change in pull request #30977:
URL: https://github.com/apache/spark/pull/30977#discussion_r550370377
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/randomExpressions.scala
##########
@@ -44,8 +44,8 @@ abstract class RDG extends UnaryExpression with
ExpectsInputTypes with Stateful
}
@transient protected lazy val seed: Long = child match {
- case Literal(s, IntegerType) => s.asInstanceOf[Int]
- case Literal(s, LongType) => s.asInstanceOf[Long]
+ case e if e.dataType == IntegerType => e.eval().asInstanceOf[Int]
+ case e if e.dataType == LongType => e.eval().asInstanceOf[Long]
Review comment:
What happens if this is not `foldable`, @maropu ? I'm wondering if
`e.eval()` is safe here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
