Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5575#discussion_r28740515
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/StandaloneWorkerShuffleService.scala
---
@@ -35,7 +35,10 @@ private[worker]
class StandaloneWorkerShuffleService(sparkConf: SparkConf,
securityManager: SecurityManager)
extends Logging {
- private val enabled =
sparkConf.getBoolean("spark.shuffle.service.enabled", false)
+ // Check both if shuffle service is enabled, and that the worker should
actually host the
+ // shuffle service in that case. (The latter is currently only used for
testing.)
+ private val enabled =
sparkConf.getBoolean("spark.shuffle.service.enabled", false) &&
+ sparkConf.getBoolean("spark.worker.shouldHostShuffleServiceIfEnabled",
true)
--- End diff --
FYI this change will conflict with
https://github.com/apache/spark/pull/4990, which makes this a general class
that Mesos can also use. If you follow my suggestion of just disabling this for
local cluster then this doesn't need to change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
