Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5578#discussion_r28743975
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -1222,20 +1224,31 @@ class SQLContext(@transient val sparkContext: 
SparkContext)
        * Returns a Catalyst Schema for the given java bean class.
        */
       protected def getSchema(beanClass: Class[_]): Seq[AttributeReference] = {
    -    val (dataType, _) = inferDataType(beanClass)
    +    val (dataType, _) = SQLContext.inferDataType(TypeToken.of(beanClass))
         dataType.asInstanceOf[StructType].fields.map { f =>
           AttributeReference(f.name, f.dataType, f.nullable)()
         }
       }
     
    +}
    +
    +object SQLContext {
    --- End diff --
    
    As long as we are going to break this out into its own object, can we move 
it to its own file and maybe name it something like `JavaTypeInference`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to