maropu commented on a change in pull request #31002:
URL: https://github.com/apache/spark/pull/31002#discussion_r551148737
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -796,11 +796,11 @@ object SQLConf {
.doc("Sets the compression codec used when writing ORC files. If either
`compression` or " +
"`orc.compress` is specified in the table-specific options/properties,
the precedence " +
"would be `compression`, `orc.compress`,
`spark.sql.orc.compression.codec`." +
- "Acceptable values include: none, uncompressed, snappy, zlib, lzo.")
+ "Acceptable values include: none, uncompressed, snappy, zlib, lzo,
zstd.")
.version("2.3.0")
.stringConf
.transform(_.toLowerCase(Locale.ROOT))
- .checkValues(Set("none", "uncompressed", "snappy", "zlib", "lzo"))
+ .checkValues(Set("none", "uncompressed", "snappy", "zlib", "lzo", "zstd"))
Review comment:
I'm not familiar with this part though, I saw the ORC code:
https://github.com/apache/orc/blob/f6b6b2ea70f1b74e2ffd897e8985ffcd1c082582/java/core/src/java/org/apache/orc/CompressionKind.java#L25-L27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
