maropu commented on a change in pull request #30965:
URL: https://github.com/apache/spark/pull/30965#discussion_r551297830
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/joinReorder/JoinReorderSuite.scala
##########
@@ -363,4 +364,18 @@ class JoinReorderSuite extends JoinReorderPlanTestBase
with StatsEstimationTestB
assertEqualJoinPlans(Optimize, originalPlan3, bestPlan3)
}
+
+ test("SPARK-33935: betterThan should be consistent") {
+ val plan1 = JoinPlan(null, null, null, Cost(300, 80))
+ val plan2 = JoinPlan(null, null, null, Cost(500, 30))
+
+ // cost1 = 300*0.7 + 80*0.3 = 234
+ // cost2 = 500*0.7 + 30*0.3 = 359
+
+ assert(!plan1.betterThan(plan1, conf))
+ assert(!plan2.betterThan(plan2, conf))
+
+ assert(plan1.betterThan(plan2, conf))
+ assert(!plan2.betterThan(plan1, conf))
Review comment:
Thanks for adding this. This fix looks fine to me. cc: @cloud-fan
@HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
