tedyu commented on a change in pull request #30984:
URL: https://github.com/apache/spark/pull/30984#discussion_r551391570
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
##########
@@ -737,6 +737,10 @@ abstract class PushableColumnBase {
}
case s: GetStructField if nestedPredicatePushdownEnabled =>
helper(s.child).map(_ :+ s.childSchema(s.ordinal).name)
+ case GetJsonObject(col, field) =>
+ val colName = col.toString.split("#")(0)
+ val fieldName = field.toString.split("\\.").last
+ Some(Seq("GetJsonObject(" + col + "," + field + ")"))
Review comment:
Please note that the actual column and field names passed to
GetJsonObject() look like the following:
```
scala> spark.range(1).toDF("GetJsonObject(phone#37,$.phone)").show()
java.lang.IllegalArgumentException: Error while instantiating
'org.apache.spark.sql.hive.HiveSessionStateBuilder':
at
org.apache.spark.sql.SparkSession$.org$apache$spark$sql$SparkSession$$instantiateSessionState(SparkSession.scala:1115)
at
org.apache.spark.sql.SparkSession.$anonfun$sessionState$2(SparkSession.scala:158)
at scala.Option.getOrElse(Option.scala:189)
at
org.apache.spark.sql.SparkSession.sessionState$lzycompute(SparkSession.scala:156)
at org.apache.spark.sql.SparkSession.sessionState(SparkSession.scala:153)
at org.apache.spark.sql.Dataset.<init>(Dataset.scala:217)
at org.apache.spark.sql.SparkSession.range(SparkSession.scala:538)
at org.apache.spark.sql.SparkSession.range(SparkSession.scala:517)
at org.apache.spark.sql.SparkSession.range(SparkSession.scala:508)
... 47 elided
Caused by: java.lang.IllegalArgumentException: wrong number of arguments
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
at
org.apache.spark.sql.SparkSession$.org$apache$spark$sql$SparkSession$$instantiateSessionState(SparkSession.scala:1112)
... 55 more
```
I tried some variation of the above but couldn't get the statement to pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
