viirya commented on a change in pull request #31028:
URL: https://github.com/apache/spark/pull/31028#discussion_r551767890
##########
File path: python/setup.py
##########
@@ -125,16 +125,16 @@ def run(self):
spark_dist = os.path.join(self.install_lib, "pyspark",
"spark-distribution")
rmtree(spark_dist, ignore_errors=True)
- if ("HADOOP_VERSION" in os.environ) or ("HIVE_VERSION" in os.environ):
- # Note that SPARK_VERSION environment is just a testing purpose.
- # HIVE_VERSION environment variable is also internal for now in
case
+ if ("PYSPARK_HADOOP_VERSION" in os.environ) or ("PYSPARK_HIVE_VERSION"
in os.environ):
+ # Note that PYSPARK_VERSION environment is just a testing purpose.
Review comment:
Why also change SPARK_VERSION -> PYSPARK_VERSION here? Is it related to
PYSPARK_HADOOP_VERSION?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
