sarutak commented on a change in pull request #31023:
URL: https://github.com/apache/spark/pull/31023#discussion_r551941920
##########
File path: project/SparkBuild.scala
##########
@@ -958,18 +958,24 @@ object Unidoc {
.map(_.filterNot(_.getCanonicalPath.contains("org/apache/hadoop")))
},
- javacOptions in (JavaUnidoc, unidoc) := Seq(
- "-windowtitle", "Spark " + version.value.replaceAll("-SNAPSHOT", "") + "
JavaDoc",
- "-public",
- "-noqualifier", "java.lang",
- "-tag", """example:a:Example\:""",
- "-tag", """note:a:Note\:""",
- "-tag", "group:X",
- "-tag", "tparam:X",
- "-tag", "constructor:X",
- "-tag", "todo:X",
- "-tag", "groupname:X"
- ),
+ javacOptions in (JavaUnidoc, unidoc) := {
+ val versionParts = System.getProperty("java.version").split("[+.\\-]+",
3)
+ var major = versionParts(0).toInt
+ if (major == 1) major = versionParts(1).toInt
Review comment:
It's impossible isn't it? `major` in the condition expression is
undefined yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
