dongjoon-hyun commented on a change in pull request #31026:
URL: https://github.com/apache/spark/pull/31026#discussion_r552408180



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -2150,9 +2150,6 @@ class Analyzer(override val catalogManager: 
CatalogManager)
                         lead.copy(ignoreNulls = ignoreNulls)
                       case lag: Lag =>
                         lag.copy(ignoreNulls = ignoreNulls)
-                      case _ =>
-                        throw 
QueryCompilationErrors.functionWithUnsupportedSyntaxError(
-                          owf.prettyName, "IGNORE NULLS")

Review comment:
       For the example, GitHub Action job is not triggered correctly due to 
Apache's 3rd party action ban (`linter` job's `setup-r` action). Since I 
recovered the GitHub Action, I remember it correctly.
   ![Screen Shot 2021-01-05 at 11 16 19 
PM](https://user-images.githubusercontent.com/9700541/103740432-0ca45e80-4fac-11eb-9adf-683ae9ae2419.png)
   
   There is no known cases where Scala 2.13 compiler miss. If there is a 
missing case, we should report to Scala community.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to