nicknezis commented on pull request #31059: URL: https://github.com/apache/spark/pull/31059#issuecomment-755571831
> I don't think this actually updates the kryo version used? the pom.xml files were not changed. > This could be fine, but we'll have to see if it breaks anything once Spark actually uses it. > > The migration guide is at https://github.com/EsotericSoftware/kryo/wiki/Migration-to-v5 > For example requiring registration by default may be a breaking change that we have to explicitly disable. Yes I was a little bit unsure about this. The pom.xml files didn't seem to reference a version. And the previous PR #22179 that updated the version to 4.0.2 seemed to only touch these files. If you can let me know where the version information is actually stored, I can update that and redo any testing and follow-up code edits. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
