holdenk commented on pull request #31071: URL: https://github.com/apache/spark/pull/31071#issuecomment-755892949
Sounds good, I’ll change it over. On Wed, Jan 6, 2021 at 9:19 PM Dongjoon Hyun <[email protected]> wrote: > *@dongjoon-hyun* commented on this pull request. > ------------------------------ > > In > resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshot.scala > <https://github.com/apache/spark/pull/31071#discussion_r553114305>: > > > case t if t.getExitCode != 0 => > PodFailed(pod) > case t if t.getExitCode == 0 => > PodSucceeded(pod) > + // Fall through case > case _ => > PodRunning(pod) > } > > Yes, I do because it's shorter. :) > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/31071#discussion_r553114305>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAAOT5PLDXUFED5M34LOVTLSYU75XANCNFSM4VX7W6RA> > . > -- Cell : 425-233-8271 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
