Github user vruusmann commented on the pull request:
https://github.com/apache/spark/pull/3062#issuecomment-94781590
@selvinsource The benefits of upgrading the `pmml-model` dependency are
more obvious if you are in the business of consuming PMML documents (eg. speed
and memory usage improvements). But I still recommend you to make this move.
The upgrade from 1.1.7 to 1.1.13 should be very easy. The upgrade from
1.1.13 to 1.1.14 may require touching Java source code here and there (eg.
rearranging the arguments of value constructors, correcting the case of
selected method names).
The upgrade will change the list of your transitive dependencies. So, you
should probably to the upgrade first, and edit `LICENSE` and `NOTICE` files
second.
Moreover, I think that after the upgrade it will be safe to exclude
`FastInfoset` and `istack-commons-runtime` dependencies from the build (using
Maven's dependency exclusion mechanism) without affecting the PMML exporter
functionality. These dependencies take care of managing SAX Locator information
when unmarshalling. But since you are creating new PMML documents in memory
from scratch, then they are not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
