aokolnychyi commented on a change in pull request #31083:
URL: https://github.com/apache/spark/pull/31083#discussion_r553521437



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
##########
@@ -627,21 +627,22 @@ abstract class StreamExecution(
       inputPlan.schema,
       new CaseInsensitiveStringMap(options.asJava))
     val writeBuilder = table.newWriteBuilder(info)
-    outputMode match {
+    val write = outputMode match {

Review comment:
       This probably deserves an independent PR. Required distribution and sort 
for streaming plans is a separate discussion we should have once we cover the 
batch plans.
   
   I could technically keep using the old deprecated method here and just adapt 
`InMemoryTable` implementation until we have a proper plan for streaming nodes. 
As an alternative, I can move this piece to use `Write`s so that data sources 
that build `Write`s will work correctly as an intermediate step.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to