sarutak commented on a change in pull request #31015: URL: https://github.com/apache/spark/pull/31015#discussion_r553711942
########## File path: core/src/test/scala/org/apache/spark/ui/jobs/AllJobsPageSuite.scala ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.ui.jobs + +import javax.servlet.http.HttpServletRequest + +import org.mockito.Mockito._ + +import org.apache.spark.SparkFunSuite +import org.apache.spark.status.AppStatusStore +import org.apache.spark.status.api.v1 + +class AllJobsPageSuite extends SparkFunSuite { Review comment: I mean we need to test whether the page is rendered and the scheduling mode is displayed with no error when we visit `http://localhost:4040/jobs/` even though we configure the scheduling mode like `spark.scheduler.mode=fair` instead of `spark.scheculer.mode=FAIR`. Currently, we get the following error when we visit `http://localhost:4040/jobs/` if we set the scheduling mode in lower case.  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
