Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5455#discussion_r28801082
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -994,19 +996,22 @@ private[spark] object SerDe extends Serializable {
out.write(Opcodes.BINSTRING)
out.write(PickleUtils.integer_to_bytes(bytes.length))
out.write(bytes)
- out.write(Opcodes.TUPLE3)
+ out.write(Opcodes.BININT)
+ out.write(PickleUtils.integer_to_bytes(isTransposed))
+ out.write(Opcodes.TUPLE)
}
def construct(args: Array[Object]): Object = {
- if (args.length != 3) {
- throw new PickleException("should be 3")
+ if (args.length != 4) {
+ throw new PickleException("should be 4")
}
val bytes = getBytes(args(2))
val n = bytes.length / 8
val values = new Array[Double](n)
val order = ByteOrder.nativeOrder()
+ val isTransposed = if (args(3).asInstanceOf[Int] == 1) true else
false
--- End diff --
Move this line after `ByteBuffer.wrap...` and simplify it to `val
isTransposed = args(3).asInstanceOf[Int] == 1`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
