jaceklaskowski commented on a change in pull request #31073:
URL: https://github.com/apache/spark/pull/31073#discussion_r553971028
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
##########
@@ -2841,6 +2841,31 @@ object functions {
// DateTime functions
//////////////////////////////////////////////////////////////////////////////////////////////
+ /**
+ * Creates a datetime interval
+ *
+ * @param years Number of years
+ * @param months Number of months
+ * @param weeks Number of weeks
+ * @param days Number of days
+ * @param hours Number of hours
+ * @param mins Number of mins
+ * @param secs Number of secs
+ * @return A datetime interval
+ * @group datetime_funcs
+ * @since 3.2.0
+ */
+ def make_interval(
+ years: Column = lit(0),
Review comment:
> Can we avoid default argument? This doesn't work in Java.
That's why I recommend focusing on one language only and think of others
later. For Java we might need more functions to look Scala-ish. No idea what R
requires.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
