cloud-fan commented on a change in pull request #30998:
URL: https://github.com/apache/spark/pull/30998#discussion_r553802344
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1431,4 +1431,28 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-33933: AQE broadcast should not timeout with slow map tasks") {
Review comment:
we can add retry logic to make it less likely to fail. It should be much
more stable than checking the running time.
Another way is to check the stage submission order (not the job submission
order). But seems there is no easy way to get the stage submission order. Maybe
we can add logs and check the log?
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1431,4 +1431,28 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-33933: AQE broadcast should not timeout with slow map tasks") {
Review comment:
we can add retry logic to make it less likely to fail. It should be much
more stable than checking the running time.
Another way is to check the actual stage submission order (not the job
submission order). But seems there is no easy way to get the stage submission
order. Maybe we can add logs and check the log?
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1431,4 +1431,28 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-33933: AQE broadcast should not timeout with slow map tasks") {
Review comment:
> the spark conf changed to local[2] and so the running times are faster
than before.
This shows the test is unreliable...
Checking the Spark jobs submission order should be easy to do and fast to
run, and with retry it should be unlikely to fail. It's better to check stage
submission order directly, if we can figure out how to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
