tgravescs commented on a change in pull request #30710:
URL: https://github.com/apache/spark/pull/30710#discussion_r554012961
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -1889,6 +1889,12 @@ package object config {
.doubleConf
.createWithDefault(0.75)
+ private[spark] val SPECULATION_MIN_THRESHOLD =
+ ConfigBuilder("spark.speculation.min.threshold")
+ .version("3.2.0")
Review comment:
please add the .doc section as well.
##########
File path: docs/configuration.md
##########
@@ -2309,6 +2309,16 @@ Apart from these, the following properties are also
available, and may be useful
</td>
<td>0.6.0</td>
</tr>
+<tr>
+ <td><code>spark.speculation.min.threshold</code></td>
+ <td>100ms</td>
+ <td>
+ Duplicate copies of a task will only be launched if the original copy has
been running for
Review comment:
I think we should reword a bit to be more specific about the config.
something like: Minimum amount of time a task runs before being considered for
speculation. This ....
##########
File path: docs/configuration.md
##########
@@ -2309,6 +2309,14 @@ Apart from these, the following properties are also
available, and may be useful
</td>
<td>0.6.0</td>
</tr>
+<tr>
+ <td><code>spark.speculation.min.threshold</code></td>
+ <td>100ms</td>
+ <td>
+ Minimum amount of time a task runs before being considered for speculation.
Review comment:
sorry I wasn't clear, I meant for you to keep the second sentence as
well to explain its use.
Maybe something like: "
Minimum amount of time a task runs before being considered for speculation.
This can be used to avoid launching speculative copies of tasks that are
very short."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
