aokolnychyi commented on a change in pull request #31093:
URL: https://github.com/apache/spark/pull/31093#discussion_r554306458
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
##########
@@ -274,11 +274,13 @@ class InMemoryTable(
this
}
- override def buildForBatch(): BatchWrite = writer
Review comment:
Yeah, we could leave it as is. I changed because it would previously
fail if a data source implemented the build method only.
In the next PR, I am going to implement RequireaDistributionAndOrdering.
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryTable.scala
##########
@@ -274,11 +274,13 @@ class InMemoryTable(
this
}
- override def buildForBatch(): BatchWrite = writer
Review comment:
Yeah, we could leave it as is. I changed because it would previously
fail if a data source implemented the build method only.
In the next PR, I am going to implement RequiredDistributionAndOrdering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
