Github user coderxiang commented on a diff in the pull request:
https://github.com/apache/spark/pull/5619#discussion_r28825953
--- Diff: python/pyspark/mllib/recommendation.py ---
@@ -125,13 +131,20 @@ class ALS(object):
@classmethod
def _prepare(cls, ratings):
- assert isinstance(ratings, RDD), "ratings should be RDD"
+ if isinstance(ratings, RDD):
+ pass
+ elif isinstance(ratings, DataFrame):
+ ratings = ratings.rdd
+ else:
+ raise TypeError("Ratings should be represented by either an
RDD or a DataFrame, "
+ "but got %s." % type(ratings))
--- End diff --
a minor issue: maybe better to use "%s is provided"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
