cloud-fan commented on pull request #30984: URL: https://github.com/apache/spark/pull/30984#issuecomment-757767733
I don't think it's consistent with the existing implementation, otherwise we should be using strings all around like `a > 1` instead of `GreaterThan(a, 1)`. The only exception I know of is nested columns. We use string `a.b` to represent a nested column, instead of a dedicated class. This is for backward compatibility reasons and we have a legacy config to fallback. It's also not that bad as the string representation for nested columns is pretty standard. We probably need to merge the V1 `Filter` and V2 `Expression` to support cases like this. Using string is not the right way to go. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
