MaxGekk commented on a change in pull request #29817:
URL: https://github.com/apache/spark/pull/29817#discussion_r555211907
##########
File path:
core/src/test/scala/org/apache/spark/storage/BlockManagerDecommissionIntegrationSuite.scala
##########
@@ -40,6 +40,46 @@ class BlockManagerDecommissionIntegrationSuite extends
SparkFunSuite with LocalS
val TaskEnded = "TASK_ENDED"
val JobEnded = "JOB_ENDED"
+ Seq(false, true).foreach { isEnabled =>
+ test(s"SPARK-32850: BlockManager decommission should respect the
configuration " +
+ s"(enabled=${isEnabled})") {
+ val conf = new SparkConf()
+ .setAppName("test-blockmanager-decommissioner")
+ .setMaster("local-cluster[2, 1, 1024]")
+ .set(config.DECOMMISSION_ENABLED, true)
+ .set(config.STORAGE_DECOMMISSION_ENABLED, isEnabled)
+ sc = new SparkContext(conf)
+ TestUtils.waitUntilExecutorsUp(sc, 2, 6000)
Review comment:
I got test failure in my PR #31131 (the PR is not related to the test I
believe):
```
[info] BlockManagerDecommissionIntegrationSuite:
[info] - SPARK-32850: BlockManager decommission should respect the
configuration (enabled=false) *** FAILED *** (6 seconds, 165 milliseconds)
[info] java.util.concurrent.TimeoutException: Can't find 2 executors
before 6000 milliseconds elapsed
[info] at
org.apache.spark.TestUtils$.waitUntilExecutorsUp(TestUtils.scala:374)
[info] at
org.apache.spark.storage.BlockManagerDecommissionIntegrationSuite.$anonfun$new$2(BlockManagerDecommissionIntegrationSuite.scala:52)
[info] at
scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
