Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5383#discussion_r28828949
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Generate.scala ---
@@ -21,6 +21,16 @@ import org.apache.spark.annotation.DeveloperApi
import org.apache.spark.rdd.RDD
import org.apache.spark.sql.catalyst.expressions._
+// for lazy computing, be sure the generator.terminate() called in the
very last
+// TODO reusing the CompletionIterator?
--- End diff --
Use ScalaDoc style for class comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
