LuciferYang commented on a change in pull request #31125:
URL: https://github.com/apache/spark/pull/31125#discussion_r555471169
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/dynalloc/ExecutorMonitor.scala
##########
@@ -227,7 +227,7 @@ private[spark] class ExecutorMonitor(
}
if (updateExecutors) {
- val activeShuffleIds = shuffleStages.map(_._2).toSeq
+ val activeShuffleIds = shuffleStages.map(_._2)
Review comment:
Yes, I'm sure this conversion is redundant, the type of `shuffleStages`
is `Seq[(Int, Int)]` in Scala 2.13, and I run
`mvn clean install -Pscala-2.13 -pl core -am` locally, all test passed in
core module
```
Run completed in 36 minutes, 54 seconds.
Total number of tests run: 2710
Suites: completed 270, aborted 0
Tests: succeeded 2710, failed 0, canceled 4, ignored 7, pending 0
All tests passed.
```
I will do more more local tests to verify other changes today
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
