cloud-fan commented on a change in pull request #31135:
URL: https://github.com/apache/spark/pull/31135#discussion_r555487286
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/AlterTableDropPartitionSuite.scala
##########
@@ -30,17 +30,24 @@ class AlterTableDropPartitionSuite
with CommandSuiteBase {
test("hive client calls") {
- withNamespaceAndTable("ns", "tbl") { t =>
- sql(s"CREATE TABLE $t (id int, part int) $defaultUsing PARTITIONED BY
(part)")
- sql(s"INSERT INTO $t PARTITION (part=0) SELECT 0")
- sql(s"INSERT INTO $t PARTITION (part=1) SELECT 1")
-
- checkHiveClientCalls(expected = 19) {
- sql(s"ALTER TABLE $t DROP PARTITION (part=0)")
- }
- sql(s"CACHE TABLE $t")
- checkHiveClientCalls(expected = 22) {
- sql(s"ALTER TABLE $t DROP PARTITION (part=1)")
+ Seq(false, true).foreach { statsOn =>
+ withSQLConf(SQLConf.AUTO_SIZE_UPDATE_ENABLED.key -> statsOn.toString) {
+ withNamespaceAndTable("ns", "tbl") { t =>
+ sql(s"CREATE TABLE $t (id int, part int) $defaultUsing PARTITIONED
BY (part)")
+ sql(s"INSERT INTO $t PARTITION (part=0) SELECT 0")
+ sql(s"INSERT INTO $t PARTITION (part=1) SELECT 1")
+ sql(s"ALTER TABLE $t ADD PARTITION (part=2)") // empty partition
+ checkHiveClientCalls(expected = if (statsOn) 27 else 19) {
+ sql(s"ALTER TABLE $t DROP PARTITION (part=2)")
+ }
+ checkHiveClientCalls(expected = if (statsOn) 32 else 19) {
Review comment:
yea we should improve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
