brandonJY commented on pull request #31108:
URL: https://github.com/apache/spark/pull/31108#issuecomment-758528257


   > Hi @brandonJY , I have three comments.
   > 
   > 1. I tried this change but it doesn't work on my environment (Pop!_OS, an 
Ubuntu variant, and Firefox). When I click the button you added, I get the 
following error on the browser's console.
   >    
![errorn-on-click](https://user-images.githubusercontent.com/4736016/104262487-0beb5b00-54cb-11eb-8033-e32db90b2381.png)
   > 2. At first, I couldn't notice where is the button. Users might not notice 
it's a button.
   > 3. Could you add the screenshots for before/after press the button.
   
   @sarutak  thanks for the reviewing. I have updated the code to make it more 
visiable with error fixing you mentioned. 
   Before pressing button screenshot
   
![image](https://user-images.githubusercontent.com/20021316/104295778-d7dc5e00-54fb-11eb-8b7d-cb7574534761.png)
   
   
   After pressing button screenshot
   
![image](https://user-images.githubusercontent.com/20021316/104295722-c7c47e80-54fb-11eb-8e95-ac5132251517.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to