potiuk opened a new pull request #31153:
URL: https://github.com/apache/spark/pull/31153
Changes the configuration of the cancel workflow action to skip
schedule/push events from canceling. This has the effect that duplicates of all
direct pushes (master merges or direct pushes to the spark repository are not
cancelled)
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Update to CI cancel policy to skip direct pushes. Duplicates will only be
cancelled for Pull Requests.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
[Apparenlty](https://github.com/apache/spark/pull/31104#issuecomment-758318463)
the aggressive behavior of the cancel action which also cancels duplicate
master builds is too agressive for spark community. This change spares merges
to master and scheduled builds from duplicate checking (as a result all merges
to master will be always build to completion).
The previous behavior of the action was that in case of subsequent merges to
master, only the latest one was guaranteed to complete. Other changes could be
cancelled before they complete to save job queue.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description and/or an example to show the
behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No, except if the master builds were somehow facing the users (but it's
unlikely taking into account the ASF release policy).
There was a potential that some changes that could be detected by specific
master merge failing could be detected later (in one of the subsequent builds)
which could make investigation of the root cause of failure a bit more
difficult, because it could have been introduced in one of the commits between
two completed builds merges. But this is at most impacting the timeline of
release close to release itself, not the release itself.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
This configuration parameter has been tested earlier in Airflow. We used it
initially, but since our master builds are heavy and we have extensive tests in
the PRs and investigation for failed builds is not as difficult we found that
limiting the strain on Github Action and cancelling master builds was more
important for the health of the whole ASF community and we removed that
configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
