cloud-fan commented on pull request #31152: URL: https://github.com/apache/spark/pull/31152#issuecomment-758757446
@tgravescs thanks for providing the context! I looked at the source code and I found one caller of this particular `MemoryConsumer` constructor, `HybridRowQueue`, actually supports off-heap. For `MemoryConsumer` implementations, I think they are responsible to set the memory mode correctly. We should fix `Spillable` as it only supports on-heap. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
