holdenk commented on a change in pull request #31102:
URL: https://github.com/apache/spark/pull/31102#discussion_r555961077
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerDecommissioner.scala
##########
@@ -154,7 +158,7 @@ private[storage] class BlockManagerDecommissioner(
// Shuffles which are queued for migration & number of retries so far.
// Visible in storage for testing.
private[storage] val shufflesToMigrate =
- new java.util.concurrent.ConcurrentLinkedQueue[(ShuffleBlockInfo, Int)]()
+ new java.util.concurrent.LinkedBlockingQueue[(ShuffleBlockInfo, Int)]()
Review comment:
I think we generally care more about read performance of this data
structure. In the situation where we are busy waiting we don't really care
because there isn't any data for us to migrate and the executor is exiting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
