viirya commented on a change in pull request #31154:
URL: https://github.com/apache/spark/pull/31154#discussion_r556093414
##########
File path:
external/kafka-0-10-token-provider/src/test/scala/org/apache/spark/kafka010/KafkaTokenUtilSuite.scala
##########
@@ -239,24 +239,17 @@ class KafkaTokenUtilSuite extends SparkFunSuite with
KafkaDelegationTokenTest {
assert(jaasParams.contains(tokenPassword1))
}
- test("needTokenUpdate without security credentials enabled should return
false") {
Review comment:
Shall we add some comments on `needTokenUpdate` to explain when it
should be called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
