sarutak commented on a change in pull request #31096:
URL: https://github.com/apache/spark/pull/31096#discussion_r556161684
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/ParserUtils.scala
##########
@@ -172,6 +172,20 @@ object ParserUtils {
}
sb.append(code.asInstanceOf[Char])
i += 5
+ } else if ((i + 10 < strLength) && b.charAt(i + 1) == 'U' &&
Review comment:
If we are going to use`regex` to match `\U00000000` pattern, I think
`regex` should also be used for other escape characters including `\u0000` and
`\000`.
So I focus on 32-bit unicode escape in this PR and will refactor the code
for all the escape characters with `regex`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
