ekoifman commented on pull request #30829: URL: https://github.com/apache/spark/pull/30829#issuecomment-759603162
@cloud-fan I don't think you can move `OptimizeSkewJoin` to `queryStagePreparationRules` for 2 reasons 1. `OptimizeSkewJoin` logically has to run after `CoalesceShufflePartitions`. (Also, comments on `queryStageOptimizerRules` state the same) 2. `queryStagePreparationRules` may run before all child `QueryStageExec` of the stage have materialized (called from `reOptimize()`) but `OptimizeSkewJoin` has to know the input from both sides. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
