weixiuli commented on a change in pull request #30716:
URL: https://github.com/apache/spark/pull/30716#discussion_r557333541
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -251,6 +251,26 @@ private[spark] class DAGScheduler(
private val pushBasedShuffleEnabled =
Utils.isPushBasedShuffleEnabled(sc.getConf)
+ private def shouldUnregisterMapOutput(mapStage: Stage, fetchFailed:
FetchFailed,
+ stageId: Int, stageAttemptId: Int): Boolean = {
+ if (!runningStages.contains(mapStage)) {
+ true
+ } else if (taskScheduler == null) {
+ true
+ } else {
+ val latestInfo = mapStage.latestInfo
+ if (latestInfo == null) {
+ true
+ } else {
+ taskScheduler.taskSetManagerForAttempt(
+ latestInfo.stageId, latestInfo.attemptNumber()) match {
+ case Some(tsm: TaskSetManager) =>
!tsm.hasPartitionId(fetchFailed.mapId.toInt)
+ case _ => true
Review comment:
Compared with before, I think this is acceptable, do you have any idea?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
