cloud-fan commented on a change in pull request #31178:
URL: https://github.com/apache/spark/pull/31178#discussion_r557843329
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/window/WindowExecBase.scala
##########
@@ -149,8 +150,8 @@ trait WindowExecBase extends UnaryExecNode {
case AggregateExpression(f, _, _, _, _) => collect("AGGREGATE",
frame, e, f)
case f: FrameLessOffsetWindowFunction =>
collect("FRAME_LESS_OFFSET", f.fakeFrame, e, f)
- case f: OffsetWindowFunction if !f.ignoreNulls &&
- frame.frameType == RowFrame && frame.lower == UnboundedPreceding
=>
+ case f: OffsetWindowFunction if frame.frameType == RowFrame &&
+ frame.lower == UnboundedPreceding =>
frame.upper match {
Review comment:
if we go with the `case _ => collect("AGGREGATE", frame, e, f)` branch,
do we still support ignore nulls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
