zero323 commented on a change in pull request #30985:
URL: https://github.com/apache/spark/pull/30985#discussion_r558323215
##########
File path: python/pyspark/worker.py
##########
@@ -500,7 +501,10 @@ def main(infile, outfile):
except (resource.error, OSError, ValueError) as e:
# not all systems support resource limits, so warn instead of
failing
- print("WARN: Failed to set memory limit: {0}\n".format(e),
file=sys.stderr)
+ warnings.warn(
+ "Failed to set memory limit: {0}\n".format(e),
+ ResourceWarning
+ )
Review comment:
Good catch. Could use `warnings.showwarning` instead? It supports
writing to `_io.TextIOWrapper`, so we could probably do something similar to
this:
```python
warnings.showwarning(
"Failed to set memory limit: {0}\n".format(e),
ResourceWarning,
__file__,
0, # Getting line number without inspect will be tricky
sys.stdout
)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
