attilapiros commented on a change in pull request #31102:
URL: https://github.com/apache/spark/pull/31102#discussion_r558337665
##########
File path:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
##########
@@ -287,8 +287,15 @@ private[spark] class CoarseGrainedExecutorBackend(
logInfo(msg)
try {
decommissioned = true
- if (env.conf.get(STORAGE_DECOMMISSION_ENABLED)) {
+ val migrationEnabled = env.conf.get(STORAGE_DECOMMISSION_ENABLED) &&
+ (env.conf.get(STORAGE_DECOMMISSION_RDD_BLOCKS_ENABLED) ||
+ env.conf.get(STORAGE_DECOMMISSION_SHUFFLE_BLOCKS_ENABLED))
+ if (migrationEnabled) {
env.blockManager.decommissionBlockManager()
+ } else if (env.conf.get(STORAGE_DECOMMISSION_ENABLED)) {
Review comment:
By removing the `STORAGE_DECOMMISSION_ENABLED` config this part would
simply disappear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
