MaxGekk commented on a change in pull request #31066:
URL: https://github.com/apache/spark/pull/31066#discussion_r558350685
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/PartitionedTablePerfStatsSuite.scala
##########
@@ -405,8 +405,8 @@ class PartitionedTablePerfStatsSuite
})
executorPool.shutdown()
executorPool.awaitTermination(30, TimeUnit.SECONDS)
- assert(HiveCatalogMetrics.METRIC_FILES_DISCOVERED.getCount() == 50)
-
assert(HiveCatalogMetrics.METRIC_PARALLEL_LISTING_JOB_COUNT.getCount() == 1)
+ assert(HiveCatalogMetrics.METRIC_FILES_DISCOVERED.getCount() == 100)
+
assert(HiveCatalogMetrics.METRIC_PARALLEL_LISTING_JOB_COUNT.getCount() == 2)
Review comment:
I think there are following cases for `SessionCatalog. refreshTable`:
1. Modification in a table that don't affect table data. For example,
updating table stats
2. Table data cache is updated/handled somehow separately like `DROP TABLE`
drop the cache or `ALTER TABLE table1 RENAME TO table2` re-creates the cache
itself
Other cases are for `CatalogImpl.refreshTable()`, it seems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
