HyukjinKwon commented on a change in pull request #31196:
URL: https://github.com/apache/spark/pull/31196#discussion_r559157951



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/LogicalRelation.scala
##########
@@ -64,7 +64,8 @@ case class LogicalRelation(
   }
 
   override def simpleString(maxFields: Int): String = {
-    s"Relation[${truncatedString(output, ",", maxFields)}] $relation"
+    s"Relation ${catalogTable.map(_.identifier.unquotedString).getOrElse("")}" 
+
+      s"[${truncatedString(output, ",", maxFields)}] $relation"

Review comment:
       The problem is that it doesn't seem to show a table name: 
https://github.com/apache/spark/blob/e3058ba17cb4512537953eb4ded884e24ee93ba2/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileDataSourceV2.scala#L66-L71
   
   Is it because `Table` API lets users to implement what name it returns, and 
Spark does not implement a catalog for its internal file sources? Seems like 
JDBC v2 supports its fully qualified name via `Identifier.toString`. If this is 
the case, I think it's fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to