dongjoon-hyun commented on a change in pull request #31219:
URL: https://github.com/apache/spark/pull/31219#discussion_r559259639



##########
File path: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala
##########
@@ -1025,6 +1003,51 @@ abstract class StateStoreSuiteBase[ProviderClass <: 
StateStoreProvider]
       }
     }
   }
+
+  def getDefaultSQLConf(minDeltasForSnapshot: Int, numOfVersToRetainInMemory: 
Int): SQLConf
+  def getDefaultStoreConf(): StateStoreConf = StateStoreConf.empty

Review comment:
       For these two functions, shall we add some function comments like the 
other functions, `newStoreProvider` and `getLatestData`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to